Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-4144 Disallow unique_ptr<T&, D> #5201

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Implement LWG-4144 Disallow unique_ptr<T&, D> #5201

merged 2 commits into from
Jan 14, 2025

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #5125.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner December 23, 2024 00:50
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Jan 4, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jan 4, 2025
@StephanTLavavej StephanTLavavej removed their assignment Jan 7, 2025
@StephanTLavavej StephanTLavavej mentioned this pull request Jan 7, 2025
Open
@StephanTLavavej StephanTLavavej self-assigned this Jan 13, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6d5d462 into microsoft:main Jan 14, 2025
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for implementing this unique LWG issue resolution! 😹 🎉 😻

@frederick-vs-ja frederick-vs-ja deleted the lwg-4144 branch January 14, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-4144 Disallow unique_ptr<T&, D>
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter