<format>: Alternate form general floating-point width handling #5261
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
@microsoft-github-policy-service agree |
StephanTLavavej
requested changes
Feb 1, 2025
...std/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/env.lst
Outdated
Show resolved
Hide resolved
...std/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/env.lst
Outdated
Show resolved
Hide resolved
...td/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/test.cpp
Outdated
Show resolved
Hide resolved
...td/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/test.cpp
Outdated
Show resolved
Hide resolved
AlexGuteniev
reviewed
Feb 1, 2025
...std/tests/GH_005011_format_alternate_form_general_floating_point_can_mishandle_width/env.lst
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Feb 3, 2025
|
Thank you, looks great! 😻 We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, probably this week but maybe next week depending on how busy I am. (There's plenty of time to get fixes into 17.14 Preview 3.) I'll post comments here as I prepare your PR for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5011