Skip to content

<vector>: Avoid a compiler warning with Defect Report P2280R4 #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 3 commits into from
May 28, 2025
Merged

<vector>: Avoid a compiler warning with Defect Report P2280R4 #5550

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29f77ca
Avoid a compiler warning with Defect Report P2280R4
StephanTLavavej May 27, 2025
0987306
Use a `const bool` instead.
StephanTLavavej May 27, 2025
a306d2d
Expand comment slightly.
StephanTLavavej May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion stl/inc/vector
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3195,7 +3195,10 @@ public:
_NODISCARD _CONSTEXPR20 size_type max_size() const noexcept {
constexpr auto _Diff_max = static_cast<size_type>(_STD _Max_limit<difference_type>());
const size_type _Ints_max = this->_Myvec.max_size();
if (_Ints_max > _Diff_max / _VBITS) { // max_size bound by difference_type limits

// Use a const bool to avoid warning C4127 "conditional expression is constant" with Defect Report P2280R4
const bool _Would_overflow = _Ints_max > _Diff_max / _VBITS;
if (_Would_overflow) { // max_size bound by difference_type limits
return _Diff_max;
}

Expand Down