-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Tests for P1831 and workaround for DevCom-10948908 #5670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
This issue also exists in Clang19 and Clang20, but it will be fixed in Clang21. See commit. |
298cb80 to
8ba4b86
Compare
8ba4b86 to
9dde47e
Compare
|
@StephanTLavavej What is the difference between checks numbered 3, 4, and others in Build and Test x64 x64? They unexpectedly passed some new tests. |
#1414 originally introduced this feature, but #2794 concisely explains it:
If you go to the pipeline run webpage and click on the results tab, you'll see a list of the failed tests. |
Based on your explanation, I believe I have found a clue to reproduce the issue. Thanks! |
|
The workaround for |
|
The MSVC team believes a CWG issue is needed, so it may not be fixed in the short term. How should STL adapt to this situation? @StephanTLavavej |
|
@YexuanXiao Thanks for looking into this. Because MSVC's behavior is unlikely to change in the moderate future and the impact of missing deprecation warnings for volatile machinery is highly limited, I believe I would prefer to abandon this attempt. I appreciate the effort you've put into it, but at this point I don't think making changes here is worth the complexity, risk, and time. |
Even with /W3, MSVC doesn't respect the
[[deprecated]]attribute of template specializations (DevCom-10948908).Therefore, the macro
_CXX20_DEPRECATE_VOLATILEhas no effect withtuple_size,tuple_elements,variant_sizeandvariant_alternatives.Due to another bug of MSVC, applying the
[[deprecated]]attribute directly totypestill has no effect, so it can only be applied to_Mybase. Since my attempt to reproduce it failed, I cannot report it as another bug. When DevCom-10948908 is fixed, this bug may still persist, but all two workaround can be removed.