-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Optimize all_of / any_of / none_of for vector<bool> with some predicates
#5802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexGuteniev
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
AlexGuteniev:meow_of_boo!
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+268
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fac25e9 to
092ea87
Compare
all_of / any_of / none_of for vector<bool> with some predicatesall_of / any_of / none_of for vector<bool> with some predicates
AlexGuteniev
commented
Oct 30, 2025
| template <alg Alg, content Content, class Pred = identity> | ||
| void meow_of(benchmark::State& state) { | ||
| const auto size = static_cast<size_t>(state.range(0)); | ||
| vector<bool, not_highly_aligned_allocator<bool>> source(size); |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not currently vectorized, so not_highly_aligned_allocator currently serves no purpose, as not-overaligning only matters for vectorization, but:
- It can be vectorized manually in the future
- gcc with
-O3would vectorize this, so the target compilers someday also might
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #625, specifically #625 (comment) items 5, 6, 7
Follow up to #5769
⚙️ Optimization
Similarly to
transform, we can map bool functor to underlying integer vector functor. Although we have to do the operation on integer of bits after this.identitylooking like ideal functor to use, asbools are already boolean, and we just need to apply the algorithm. We can also supportlogical_not, which we have already mapped, although it is obscure to use.Sure
identityis C++20, but that's fine to optimize only new standard modes.As the algorithm uses one range, we can handle any offset without introducing too much complexity. Some complexity is still introduced by this though.
As the resulting flow is not very simple, but is the same for all three, the traits approach from the vector algorithms seems suitable.
Vectorization
Auto vectorization does not work here. @Alcaro suggested that from abstract machine view point the memory load would be invented if they happen past the early return point.
We can vectorize manually. It will be inefficient if early return happens really early, but may be a good idea overall. Not this time though.
⏱️ Benchmark results