Skip to content

Conversation

@mirion-dev
Copy link

@mirion-dev mirion-dev commented Nov 20, 2025

Fixes #5886.

@mirion-dev mirion-dev requested a review from a team as a code owner November 20, 2025 13:46
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Nov 20, 2025
@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Nov 20, 2025

I think it's better to remove the issue number from the PR title. Things will be confusing if it goes into squashed commit message.

@mirion-dev mirion-dev changed the title Enable bidirectional optimization for non-common ranges in std::ranges::partition (Fixes #5886) Enable bidirectional optimization for non-common ranges in std::ranges::partition Nov 20, 2025
@StephanTLavavej StephanTLavavej added bug Something isn't working ranges C++20/23 ranges labels Nov 20, 2025
@vmichal
Copy link

vmichal commented Nov 23, 2025

Hi, just for completeness, this PR is not set to close the corresponding issue #5886 on merge.
I'd say it would help the PR process to indicate that properly (if you are certain the PR actually solves the issue, ofc. It looks good to me).

@mirion-dev
Copy link
Author

Hi, just for completeness, this PR is not set to close the corresponding issue #5886 on merge. I'd say it would help the PR process to indicate that properly (if you are certain the PR actually solves the issue, ofc. It looks good to me).

Hi, thanks for the reminder! I've updated the description. I actually wasn't aware of the auto-close feature.

@StephanTLavavej
Copy link
Member

Thanks! 😻 I verified with a static_assert that we have existing test coverage for bidi-but-not-common ranges in libcxx std/algorithms/alg.modifying.operations/alg.partitions/ranges_partition.pass.cpp and std P0896R4_ranges_alg_partition.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Nov 25, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Nov 25, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

Status: Merging

Development

Successfully merging this pull request may close these issues.

<algorithm>: std::ranges::partition falls back to forward algorithm for non-common bidirectional ranges

4 participants