Perform stricter checks in chrono::is_clock_v
#5892
Merged
+285
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…}` when `now` is a type".
tests/std/tests/P0355R7_calendars_and_time_zones_clocks/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_clocks/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_clocks/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_clocks/test.cpp
Outdated
Show resolved
Hide resolved
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Nov 27, 2025
Member
🦋 🤖 🕥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional requirements to
chrono::is_clock_vto implement https://eel.is/c++draft/time.clock.req#tab:time.clock , do not change pre-C++20_Is_clock_v.Add complete tests.
Check "
_Clock::rep= An arithmetic type or a class emulating an arithmetic type" is missing until #1909 is resolved.Fixes #5827