<functional>: unwrap move_only_function with abominable and noexcept types
#5917
+144
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
enhancement
AlexGuteniev
force-pushed
the
abominable
branch
from
6d76684 to
362c4f8
Compare
StephanTLavavej
approved these changes
Jan 17, 2026
StephanTLavavej
approved these changes
Jan 18, 2026
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
📦 🎁 💝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5504.
Follow up on #5808.
📦 Newly unwrapped cases
move_only_function<R(Args...) cv1-ref1-noex1>(move_only_function<R(Args...) cv2-ref2-noex2>(callable));wherenoexceptandconstmay be present in only inner, and&or&&may be present in only outermove_only_function<R(Args...) cv-ref>(function<R(Args...)>(callable))where cv-ref can haveconst,&, and&&.In the tests make sure the type system is not broken, and the cases which are not supposed to compile, still do not compile.
🐿️ Squirrelly case
Inner
noexcept, outer non-noexceptcase is squirrelly.To make sure we adhere to Strict Aliasing rule, I've made
_Function_basenot dependent on whether we havenoexceptsignature or not. so that noexcept base can be wrapped in non-noexcept base safely.