<atomic>: drop _Atomic_reinterpret_as
#5973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
commented
Dec 22, 2025
AlexGuteniev
force-pushed
the
atomic-bits
branch
from
045c67e to
6f8da55
Compare
BillyONeal
approved these changes
Dec 22, 2025
StephanTLavavej
approved these changes
Jan 7, 2026
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
I keep yelling at the engineers to invent me a time machine but I'm guessing they never succeed as they didn't deliver it to me yesterday |
Member
0️⃣ 1️⃣ 0️⃣ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the change is mostly clarity. Bit cast is a vocabulary function.
_Bit_castwas invented too late, otherwise_Atomic_reinterpret_asshould have been_Bit_castall along.In addition to size checks,
_Atomic_reinterpret_asalso check for integrality, but that's an arbitrary requirement we don't really need to enforce.Bit cast has some triviality check, which spotted unwrapped
_Storage_foron lines 927 and 1062 (944 and 1080 before the change), fixed as a separate commit.