constexpr for std::array Comparisons #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Mar 11, 2020
ggweinand
force-pushed
the
constexprForArrayComparisons
branch
2 times, most recently
from
9f112b4 to
80b5623
Compare
CaseyCarter
reviewed
Mar 20, 2020
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
suggested changes
Mar 23, 2020
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ggweinand
force-pushed
the
constexprForArrayComparisons
branch
from
e1c2a15 to
09b6b49
Compare
StephanTLavavej
approved these changes
Mar 27, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good! Minor suggestions.
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P1023R0_constexpr_for_array_comparisons/test.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
approved these changes
Mar 29, 2020
StephanTLavavej
approved these changes
Mar 29, 2020
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
ggweinand
force-pushed
the
constexprForArrayComparisons
branch
from
17eb416 to
c187f72
Compare
CaseyCarter
suggested changes
Mar 31, 2020
CaseyCarter
approved these changes
Mar 31, 2020
StephanTLavavej
approved these changes
Mar 31, 2020
Member
|
Congratulations on checking in your first C++20 feature, @Weheineman! 😸 |
Contributor
|
Congratulations 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #49.
stl/inc/array: The functions whereconstexprneeded to be added just called other functions which are nowconstexpr, so only_CONSTEXPR20was added.stl/inc/yvals_core.h: Modified the definition of the feature test macro__cpp_lib_array_constexprfor cxx20 mode.tests/std/tests/VSO_0157762_feature_test_macros/test.cpp: Added test coverage for__cpp_lib_array_constexprin cxx20 mode.Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.