Skip to content

<bitset>: Make bitset::all work like bitset::any #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaseyCarter merged 10 commits into from
Apr 3, 2020
Merged

<bitset>: Make bitset::all work like bitset::any #671

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a1aa10f
Fix #669
AlexGuteniev Apr 1, 2020
cbc7a31
formatting
AlexGuteniev Apr 1, 2020
03f5f15
@AdamBucior suggested
AlexGuteniev Apr 1, 2020
4b970ef
Suppress warning to make build pass
AlexGuteniev Apr 1, 2020
62b8882
Update stl/inc/bitset
AlexGuteniev Apr 2, 2020
0f62264
constexpr cache to avoid warning without suppression
AlexGuteniev Apr 2, 2020
989d38d
true of course!
AlexGuteniev Apr 2, 2020
9c0a259
trim whitespace
AlexGuteniev Apr 2, 2020
2a615ef
It looks like `logical or` actually
AlexGuteniev Apr 2, 2020
e705447
Add blank line to indicate unchained control flow
CaseyCarter Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion stl/inc/bitset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,19 @@ public:
}

_NODISCARD bool all() const noexcept {
return count() == size();
constexpr bool _Zero_length = _Bits == 0;
if _CONSTEXPR_IF (_Zero_length) { // must test for this, otherwise would count one full word
return true;
}

constexpr bool _No_padding = _Bits % _Bitsperword == 0;
for (size_t _Wpos = 0; _Wpos < _Words + _No_padding; ++_Wpos) {
if (_Array[_Wpos] != ~static_cast<_Ty>(0)) {
return false;
}
}

return _No_padding || _Array[_Words] == (static_cast<_Ty>(1) << (_Bits % _Bitsperword)) - 1;
}

_NODISCARD bitset operator<<(size_t _Pos) const noexcept {
Expand Down