Skip to content

Changes to support the compiler portion of P1152R4 "deprecating volatile" #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaseyCarter merged 7 commits into from
Apr 4, 2020
Merged

Changes to support the compiler portion of P1152R4 "deprecating volatile" #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
624e11b
Updates for MSVC implementation of P1152R4 "deprecating volatile"
CaseyCarter Apr 2, 2020
afd3312
More library fixes:
CaseyCarter Apr 2, 2020
fecea71
Update LLVM reference again
CaseyCarter Apr 2, 2020
f0ac48c
Update static_asserts in optional::value_or and any_cast
CaseyCarter Apr 2, 2020
26cb32e
Add a throwaway addCompilerFlags to LibcxxTestFormat
CaseyCarter Apr 3, 2020
b4095f9
Update tests/utils/stl/test/format.py
CaseyCarter Apr 3, 2020
99a51a1
Enable volatile deprecation warnings in STL's std and libcxx test suites
CaseyCarter Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm-project
Open in desktop
Submodule llvm-project updated 4162 files
25 changes: 13 additions & 12 deletions stl/inc/any
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,40 +401,41 @@ _NODISCARD _ValueType* any_cast(any* const _Any) noexcept {
}

template <class _Ty>
_NODISCARD _Ty any_cast(const any& _Any) { // retrieve _Any's contained value as _Ty
static_assert(is_constructible_v<_Ty, const _Remove_cvref_t<_Ty>&>,
"any_cast<T>(const any&) requires T to be constructible from const remove_cv_t<remove_reference_t<T>>&");
_NODISCARD remove_cv_t<_Ty> any_cast(const any& _Any) {
static_assert(is_constructible_v<remove_cv_t<_Ty>, const _Remove_cvref_t<_Ty>&>,
"any_cast<T>(const any&) requires remove_cv_t<T> to be constructible from "
"const remove_cv_t<remove_reference_t<T>>&");

const auto _Ptr = _STD any_cast<_Remove_cvref_t<_Ty>>(&_Any);
if (!_Ptr) {
_Throw_bad_any_cast();
}

return static_cast<_Ty>(*_Ptr);
return static_cast<remove_cv_t<_Ty>>(*_Ptr);
}
template <class _Ty>
_NODISCARD _Ty any_cast(any& _Any) { // retrieve _Any's contained value as _Ty
static_assert(is_constructible_v<_Ty, _Remove_cvref_t<_Ty>&>,
"any_cast<T>(any&) requires T to be constructible from remove_cv_t<remove_reference_t<T>>&");
_NODISCARD remove_cv_t<_Ty> any_cast(any& _Any) {
static_assert(is_constructible_v<remove_cv_t<_Ty>, _Remove_cvref_t<_Ty>&>,
"any_cast<T>(any&) requires remove_cv_t<T> to be constructible from remove_cv_t<remove_reference_t<T>>&");

const auto _Ptr = _STD any_cast<_Remove_cvref_t<_Ty>>(&_Any);
if (!_Ptr) {
_Throw_bad_any_cast();
}

return static_cast<_Ty>(*_Ptr);
return static_cast<remove_cv_t<_Ty>>(*_Ptr);
}
template <class _Ty>
_NODISCARD _Ty any_cast(any&& _Any) { // retrieve _Any's contained value as _Ty
static_assert(is_constructible_v<_Ty, _Remove_cvref_t<_Ty>>,
"any_cast<T>(any&&) requires T to be constructible from remove_cv_t<remove_reference_t<T>>");
_NODISCARD remove_cv_t<_Ty> any_cast(any&& _Any) {
static_assert(is_constructible_v<remove_cv_t<_Ty>, _Remove_cvref_t<_Ty>>,
"any_cast<T>(any&&) requires remove_cv_t<T> to be constructible from remove_cv_t<remove_reference_t<T>>");

const auto _Ptr = _STD any_cast<_Remove_cvref_t<_Ty>>(&_Any);
if (!_Ptr) {
_Throw_bad_any_cast();
}

return static_cast<_Ty>(_STD move(*_Ptr));
return static_cast<remove_cv_t<_Ty>>(_STD move(*_Ptr));
}

_STD_END
Expand Down
20 changes: 10 additions & 10 deletions stl/inc/optional
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,32 +394,32 @@ public:
}

template <class _Ty2>
_NODISCARD constexpr _Ty value_or(_Ty2&& _Right) const& {
static_assert(is_copy_constructible_v<_Ty>,
"The const overload of optional<T>::value_or requires T to be copy constructible "
"(N4828 [optional.observe]/18).");
_NODISCARD constexpr remove_cv_t<_Ty> value_or(_Ty2&& _Right) const& {
Copy link
Contributor Author

@CaseyCarter CaseyCarter Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted an LWG issue (but not yet been assigned a number) to make the changes to both value_or overloads Standard.

static_assert(is_convertible_v<const _Ty&, remove_cv_t<_Ty>>,
"The const overload of optional<T>::value_or requires const T& to be convertible to remove_cv_t<T> "
"([optional.observe]/18 as modified by LWG-XXXX).");
static_assert(is_convertible_v<_Ty2, _Ty>,
"optional<T>::value_or(U) requires U to be convertible to T (N4828 [optional.observe]/18).");

if (this->_Has_value) {
return this->_Value;
}

return static_cast<_Ty>(_STD forward<_Ty2>(_Right));
return static_cast<remove_cv_t<_Ty>>(_STD forward<_Ty2>(_Right));
}
template <class _Ty2>
_NODISCARD constexpr _Ty value_or(_Ty2&& _Right) && {
static_assert(is_move_constructible_v<_Ty>,
"The rvalue overload of optional<T>::value_or requires T to be move constructible "
"(N4828 [optional.observe]/20).");
_NODISCARD constexpr remove_cv_t<_Ty> value_or(_Ty2&& _Right) && {
static_assert(is_convertible_v<_Ty, remove_cv_t<_Ty>>,
"The rvalue overload of optional<T>::value_or requires T to be convertible to remove_cv_t<T> "
"([optional.observe]/20 as modified by LWG-XXXX).");
static_assert(is_convertible_v<_Ty2, _Ty>,
"optional<T>::value_or(U) requires U to be convertible to T (N4828 [optional.observe]/20).");

if (this->_Has_value) {
return _STD move(this->_Value);
}

return static_cast<_Ty>(_STD forward<_Ty2>(_Right));
return static_cast<remove_cv_t<_Ty>>(_STD forward<_Ty2>(_Right));
}

// modifiers [optional.object.mod]
Expand Down
7 changes: 4 additions & 3 deletions stl/inc/type_traits
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1660,13 +1660,14 @@ struct _Invoker_ret<_Unforced, false> { // selected for _Rx being _Unforced


// TYPE TRAITS FOR invoke()
template <class _To>
void _Implicitly_convert_to(_To) noexcept; // not defined

#pragma warning(push)
#pragma warning(disable : 4242) // 'identifier': conversion from '_From' to '_To', possible loss of data (/Wall)
#pragma warning(disable : 4244) // 'argument': conversion from '_From' to '_To', possible loss of data
#pragma warning(disable : 4365) // 'argument': conversion from '_From' to '_To', signed/unsigned mismatch (/Wall)
#pragma warning(disable : 5215) // '%s' a function parameter with a volatile qualified type is deprecated in C++20
Copy link
Member

@StephanTLavavej StephanTLavavej Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it somewhat interesting that you don't need to suppress Clang -Wdeprecated-volatile here. But if there are no warnings in our test suite, I'm happy.

Copy link
Contributor Author

@CaseyCarter CaseyCarter Apr 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should; this will be in some future set of "suppress clang warnings that don't show up because system header" 🤷‍♂ .

template <class _To>
void _Implicitly_convert_to(_To) noexcept; // not defined

template <class _From, class _To, bool = is_convertible_v<_From, _To>, bool = is_void_v<_To>>
_INLINE_VAR constexpr bool _Is_nothrow_convertible_v = noexcept(_Implicitly_convert_to<_To>(_STD declval<_From>()));
#pragma warning(pop)
Expand Down
12 changes: 12 additions & 0 deletions stl/inc/variant
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,11 +966,23 @@ using _Variant_destroy_layer = conditional_t<conjunction_v<is_trivially_destruct
_Variant_base<_Types...>, _Variant_destroy_layer_<_Types...>>;

// CLASS TEMPLATE variant
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-volatile"
#else // ^^^ Clang / not Clang vvv
#pragma warning(push)
#pragma warning(disable : 5215) // '%s' a function parameter with volatile qualified type is deprecated in C++20
#endif // __clang__
template <size_t _Idx, class _Ty>
struct _Variant_init_single_overload {
using _FTy = _Meta_list<integral_constant<size_t, _Idx>, _Ty> (*)(_Ty);
operator _FTy();
};
#ifdef __clang__
#pragma clang diagnostic pop
#else // ^^^ Clang / not Clang vvv
#pragma warning(pop)
#endif // __clang__

template <class _Indices, class... _Types>
struct _Variant_init_overload_set_;
Expand Down
9 changes: 5 additions & 4 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,8 @@ std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align_
std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.array/new_size_nothrow.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array_fsizeddeallocation.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete_fsizeddeallocation.sh.cpp SKIP
std/thread/thread.condition/thread.condition.condvarany/wait_terminates.sh.cpp SKIP

# These tests set an allocator with a max_size() too small to default construct an unordered container
Expand Down Expand Up @@ -547,9 +545,9 @@ std/containers/views/span.iterators/rend.pass.cpp SKIP

# *** CLANG ISSUES, NOT YET ANALYZED ***
# Clang doesn't enable sized deallocation by default. Should we add -fsized-deallocation or do something else?
std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array_fsizeddeallocation.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array_fsizeddeallocation.pass.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete_fsizeddeallocation.sh.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete_fsizeddeallocation.pass.cpp SKIP
std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp SKIP

# Not yet analyzed. Clang apparently defines platform macros differently from C1XX.
Expand Down Expand Up @@ -1034,6 +1032,9 @@ std/utilities/tuple/tuple.tuple/tuple.cnstr/deduct.pass.cpp:0 FAIL
# Not yet analyzed. Assertion failed: f16_8.out(mbs, c16, c_c16p, c_c16p, c8, c8+4, c8p) == F32_8::ok
std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/utf_sanity_check.pass.cpp FAIL

# Not yet analyzed. Frequent timeouts
containers\sequences\deque\deque.modifiers\insert_iter_iter.pass.cpp SKIP


# *** XFAILs WHICH PASS ***
# Not yet implemented in libcxx and marked as XFAIL
Expand Down
9 changes: 5 additions & 4 deletions tests/libcxx/skipped_tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,8 @@ language.support\support.dynamic\new.delete\new.delete.array\new_size_align_noth
language.support\support.dynamic\new.delete\new.delete.array\new_size_align.sh.cpp
language.support\support.dynamic\new.delete\new.delete.array\new_size_nothrow.sh.cpp
language.support\support.dynamic\new.delete\new.delete.array\new_size.sh.cpp
language.support\support.dynamic\new.delete\new.delete.array\sized_delete_array_fsizeddeallocation.sh.cpp
language.support\support.dynamic\new.delete\new.delete.single\new_size_align_nothrow.sh.cpp
language.support\support.dynamic\new.delete\new.delete.single\new_size_align.sh.cpp
language.support\support.dynamic\new.delete\new.delete.single\sized_delete_fsizeddeallocation.sh.cpp
thread\thread.condition\thread.condition.condvarany\wait_terminates.sh.cpp

# These tests set an allocator with a max_size() too small to default construct an unordered container
Expand Down Expand Up @@ -547,9 +545,9 @@ containers\views\span.iterators\rend.pass.cpp

# *** CLANG ISSUES, NOT YET ANALYZED ***
# Clang doesn't enable sized deallocation by default. Should we add -fsized-deallocation or do something else?
language.support\support.dynamic\new.delete\new.delete.array\sized_delete_array_fsizeddeallocation.sh.cpp
language.support\support.dynamic\new.delete\new.delete.array\sized_delete_array_fsizeddeallocation.pass.cpp
language.support\support.dynamic\new.delete\new.delete.array\sized_delete_array14.pass.cpp
language.support\support.dynamic\new.delete\new.delete.single\sized_delete_fsizeddeallocation.sh.cpp
language.support\support.dynamic\new.delete\new.delete.single\sized_delete_fsizeddeallocation.pass.cpp
language.support\support.dynamic\new.delete\new.delete.single\sized_delete14.pass.cpp

# Not yet analyzed. Clang apparently defines platform macros differently from C1XX.
Expand Down Expand Up @@ -1033,3 +1031,6 @@ utilities\tuple\tuple.tuple\tuple.cnstr\deduct.pass.cpp

# Not yet analyzed. Assertion failed: f16_8.out(mbs, c16, c_c16p, c_c16p, c8, c8+4, c8p) == F32_8::ok
localization\locale.categories\category.ctype\locale.codecvt\locale.codecvt.members\utf_sanity_check.pass.cpp

# Not yet analyzed. Frequent timeouts
containers\sequences\deque\deque.modifiers\insert_iter_iter.pass.cpp
2 changes: 1 addition & 1 deletion tests/libcxx/usual_matrix.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

PM_CL="/nologo /Od /W4 /w14061 /w14242 /w14582 /w14583 /w14587 /w14588 /w14265 /w14749 /w14841 /w14842 /w15038 /wd4643 /sdl /WX /Zc:strictStrings /D_ENABLE_STL_INTERNAL_CHECK /bigobj /FImsvc_stdlib_force_include.h /permissive-"
PM_CL="/nologo /Od /W4 /w14061 /w14242 /w14265 /w14582 /w14583 /w14587 /w14588 /wd4643 /w14749 /w14841 /w14842 /w15038 /w15214 /w15215 /w15216 /w15217 /sdl /WX /Zc:strictStrings /D_ENABLE_STL_INTERNAL_CHECK /bigobj /FImsvc_stdlib_force_include.h /permissive-"
RUNALL_CROSSLIST
PM_CL="/EHsc /MTd /D_ITERATOR_DEBUG_LEVEL=2 /std:c++latest /analyze"
PM_COMPILER="clang-cl" PM_CL="-fno-ms-compatibility -fno-delayed-template-parsing /EHsc /MTd /std:c++latest"
2 changes: 1 addition & 1 deletion tests/std/tests/prefix.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

PM_CL="/nologo /Od /W4 /w14061 /w14242 /w14582 /w14583 /w14587 /w14588 /w14265 /w14365 /w14749 /w14841 /w14842 /w15038 /sdl /WX /Zc:strictStrings /D_ENABLE_STL_INTERNAL_CHECK /D_ENFORCE_FACET_SPECIALIZATIONS=1 /bigobj"
PM_CL="/nologo /Od /W4 /w14061 /w14242 /w14265 /w14365 /w14582 /w14583 /w14587 /w14588 /w14749 /w14841 /w14842 /w15038 /w15214 /w15215 /w15216 /w15217 /sdl /WX /Zc:strictStrings /D_ENABLE_STL_INTERNAL_CHECK /D_ENFORCE_FACET_SPECIALIZATIONS=1 /bigobj"
55 changes: 29 additions & 26 deletions tests/tr1/include/tfuns.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

// common header for functional?.cpp

#pragma warning(push)
#pragma warning(disable : 5215) // '%s' a function parameter with volatile qualified type is deprecated in C++20
Copy link
Contributor Author

@CaseyCarter CaseyCarter Apr 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning push/disable/pop is the only functional change to this header; I made a non-functional drive-by fix to some weird formatting on lines 135-220.


struct funobj;
static int f0();
static int f1(const volatile funobj);
Expand Down Expand Up @@ -131,20 +134,19 @@ struct funobj { // general purpose function object
int cf6(int i1, int i2, int i3, int i4, int i5) const { // const member function with five arguments
return ::f6(*this, i1, i2, i3, i4, i5);
}
int cf7(int i1, int i2, int i3, int i4, int i5,
int i6) const { // const member function with six arguments
int cf7(int i1, int i2, int i3, int i4, int i5, int i6) const { // const member function with six arguments
return ::f7(*this, i1, i2, i3, i4, i5, i6);
}
int cf8(
int i1, int i2, int i3, int i4, int i5, int i6, int i7) const { // const member function with seven arguments
int cf8(int i1, int i2, int i3, int i4, int i5, int i6, int i7) const {
// const member function with seven arguments
return ::f8(*this, i1, i2, i3, i4, i5, i6, i7);
}
int cf9(int i1, int i2, int i3, int i4, int i5, int i6, int i7,
int i8) const { // const member function with eight arguments
int cf9(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8) const {
// const member function with eight arguments
return ::f9(*this, i1, i2, i3, i4, i5, i6, i7, i8);
}
int cf10(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8,
int i9) const { // const member function with nine arguments
int cf10(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8, int i9) const {
// const member function with nine arguments
return ::f10(*this, i1, i2, i3, i4, i5, i6, i7, i8, i9);
}

Expand All @@ -166,20 +168,19 @@ struct funobj { // general purpose function object
int vf6(int i1, int i2, int i3, int i4, int i5) volatile { // volatile member function with five arguments
return ::f6(*this, i1, i2, i3, i4, i5);
}
int vf7(int i1, int i2, int i3, int i4, int i5,
int i6) volatile { // volatile member function with six arguments
int vf7(int i1, int i2, int i3, int i4, int i5, int i6) volatile { // volatile member function with six arguments
return ::f7(*this, i1, i2, i3, i4, i5, i6);
}
int vf8(int i1, int i2, int i3, int i4, int i5, int i6,
int i7) volatile { // volatile member function with seven arguments
int vf8(int i1, int i2, int i3, int i4, int i5, int i6, int i7) volatile {
// volatile member function with seven arguments
return ::f8(*this, i1, i2, i3, i4, i5, i6, i7);
}
int vf9(int i1, int i2, int i3, int i4, int i5, int i6, int i7,
int i8) volatile { // volatile member function with eight arguments
int vf9(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8) volatile {
// volatile member function with eight arguments
return ::f9(*this, i1, i2, i3, i4, i5, i6, i7, i8);
}
int vf10(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8,
int i9) volatile { // volatile member function with nine arguments
int vf10(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8, int i9) volatile {
// volatile member function with nine arguments
return ::f10(*this, i1, i2, i3, i4, i5, i6, i7, i8, i9);
}

Expand All @@ -198,24 +199,24 @@ struct funobj { // general purpose function object
int cvf5(int i1, int i2, int i3, int i4) const volatile { // const volatile member function with four arguments
return ::f5(*this, i1, i2, i3, i4);
}
int cvf6(int i1, int i2, int i3, int i4, int i5) const
volatile { // const volatile member function with five arguments
int cvf6(int i1, int i2, int i3, int i4, int i5) const volatile {
// const volatile member function with five arguments
return ::f6(*this, i1, i2, i3, i4, i5);
}
int cvf7(int i1, int i2, int i3, int i4, int i5,
int i6) const volatile { // const volatile member function with six arguments
int cvf7(int i1, int i2, int i3, int i4, int i5, int i6) const volatile {
// const volatile member function with six arguments
return ::f7(*this, i1, i2, i3, i4, i5, i6);
}
int cvf8(int i1, int i2, int i3, int i4, int i5, int i6, int i7) const
volatile { // const volatile member function with seven arguments
int cvf8(int i1, int i2, int i3, int i4, int i5, int i6, int i7) const volatile {
// const volatile member function with seven arguments
return ::f8(*this, i1, i2, i3, i4, i5, i6, i7);
}
int cvf9(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8) const
volatile { // const volatile member function with eight arguments
int cvf9(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8) const volatile {
// const volatile member function with eight arguments
return ::f9(*this, i1, i2, i3, i4, i5, i6, i7, i8);
}
int cvf10(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8, int i9) const
volatile { // const volatile member function with nine arguments
int cvf10(int i1, int i2, int i3, int i4, int i5, int i6, int i7, int i8, int i9) const volatile {
// const volatile member function with nine arguments
return ::f10(*this, i1, i2, i3, i4, i5, i6, i7, i8, i9);
}
int i0;
Expand Down Expand Up @@ -626,3 +627,5 @@ const T& fake_lvalue(const T&& t) { // C++11 12.2 [class.temporary]/5: "A tempor
// of the full-expression containing the call."
return t;
}

#pragma warning(pop)
2 changes: 2 additions & 0 deletions tests/tr1/tests/functional4/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// test <functional>, part 4
#define TEST_NAME "<functional>, part 4"

#pragma warning(disable : 5215) // '%s' a function parameter with a volatile qualified type is deprecated in C++20

#include "tdefs.h"
#include "tfuns.h"
#include <functional>
Expand Down
6 changes: 6 additions & 0 deletions tests/utils/stl/test/format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,9 @@ def getTestsInDirectory(self, testSuite, path_in_suite,
litConfig, localConfig, test_class=LibcxxTest):
return super().getTestsInDirectory(testSuite, path_in_suite, litConfig,
localConfig, test_class)

def addCompileFlags(self, *args):
# For now, this is necessary to discard the value of
# `LIBCXX_FILESYSTEM_STATIC_TEST_ROOT` which we don't care about;
# eventually it will probably need to be made meaningful.
pass