Run format validation as its own stage and enable /BE #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbezault
added
enhancement
cbezault
force-pushed
the
separate-clang-format
branch
from
1fb6eb7 to
2736e6f
Compare
CaseyCarter
reviewed
Apr 3, 2020
Contributor
Author
|
I'm not sure what to make the displayName of the job under the "Code Format Validation" stage without it sounding silly. I've settled on "Run" for now so that on Github we see "Code Format Validation Run" for the job. |
CaseyCarter
approved these changes
Apr 3, 2020
azure-pipelines.yml
Outdated
| parameters: | ||
| targetPlatform: x86 | ||
| variables: | ||
| agentPool: 'StlBuild-2020-03-28' |
Contributor
There was a problem hiding this comment.
Don't forget to update Bullet 6 in https://github.com/microsoft/STL/wiki/Checklist-for-Updating-Toolset-and-or-Dependencies after this merges.
BillyONeal
approved these changes
Apr 3, 2020
cbezault
changed the title
AdamBucior
reviewed
Apr 3, 2020
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cbezault
force-pushed
the
separate-clang-format
branch
2 times, most recently
from
c4d2475 to
a26bd31
Compare
cbezault
changed the title
Contributor
Author
|
I always bite off more than I can chew on these PRs. It appears the VMs don't have |
Contributor
Maybe make the stage name "Code Format" and the job name "Validation". |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cbezault
force-pushed
the
separate-clang-format
branch
from
b12783c to
8374ef2
Compare
…installers, and add CUDA 10.1 RTW.
cbezault
force-pushed
the
separate-clang-format
branch
from
c39d78a to
075b9e6
Compare
StephanTLavavej
approved these changes
Apr 9, 2020
CaseyCarter
approved these changes
Apr 9, 2020
| -Name Path ` | ||
| -Value "$($environmentKey.Path);C:\Program Files\CMake\bin;C:\Program Files\LLVM\bin" | ||
|
|
||
| Write-Host 'Configuring AntiVirus exclusions...' |
Contributor
There was a problem hiding this comment.
Why is "AntiVirus" PascalCased here? PowerShell-ism leaking into the output?
fengjixuchui
added a commit
to fengjixuchui/STL
that referenced
this pull request
Apr 10, 2020
Run format validation as its own stage and enable /BE (microsoft#682)
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Aug 19, 2020
This was skipped by microsoftGH-682 on 2020-04-09. At the time, we were using VS 2019 16.6 Preview 2 (microsoftGH-645 merged on 2020-03-28). Now we're using VS 2019 16.8 Preview 1, and I can't reproduce this ICE locally. I ran x86 and x64, 30 times each, and they all passed. Let's try restoring this configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided that it is worth gating any builds and test runs behind a successful format validation step.
Also since doing this needed me to figure out how to set up a dev environment without vcpkg's help do a drive-by and enable the /BE testing.
In order to get /BE working I also need to update the VMs.