Library support for P0722R3 - Efficient sized delete for variable siz… #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed classes Implements the struct type `std::destroying_delete_t`, variable `std::destroying_delete`, and feature test macro `__cpp_lib_destroying_delete` in C++20 mode with a compiler that defines `__cpp_impl_destroying_delete`.
... and annotate to update when VS 2019 16.7p1 releases with support in MSVC.
CaseyCarter
approved these changes
Apr 7, 2020
Contributor
There was a problem hiding this comment.
FYI, I pushed some updates:
- clang-format
- Feature-test macro tests for
__cpp_impl_destroying_deleteand__cpp_lib_destroying_delete(variously enabled until we update our toolset compiler) - Enabled the libc++ destroying delete test when compiling with clang to get some library test coverage
I've also filed #693 to cleanup the messy partially-enabled bits after VS 2019 16.7p1 ships.
EDIT: (I'd port these changes to your internal PR, @joemmett, but I can't find one??!?)
StephanTLavavej
approved these changes
Apr 7, 2020
Contributor
|
Congratulations on your first contribution to the STL! |
Contributor
|
The transition comments mention 16.7 preview 1, but this doesn't seems to work on the public release of 16.7 preview 1 |
Contributor
It should work when compiling with Clang - the tests work, anyway. The compiler support for destroying delete in MSVC was delayed to 16.7p2 as indicated in #693. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed classes
Implements the struct type
std::destroying_delete_t, variablestd::destroying_delete, and feature test macro__cpp_lib_destroying_deletein C++20 mode with a compiler that defines__cpp_impl_destroying_delete.