Updated _MSVC_STL_UPDATE macro #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnatsuhara
approved these changes
Jun 15, 2020
Contributor
mnatsuhara
left a comment
mnatsuhara
left a comment
There was a problem hiding this comment.
Thanks for your contribution! 🎉
CaseyCarter
approved these changes
Jun 15, 2020
StephanTLavavej
approved these changes
Jun 16, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! I edited your pull request description slightly; you mentioned the issue that this fixes (which is great), but exactly following GitHub's "keyword" syntax allows it to formally link the issue and auto-close it when the PR is merged. See https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword for more info.
Member
|
Now that I'm back from vacation and mostly caught up on reviewing PRs, I'll port this to the MSVC-internal repo and merge it soon. |
Member
|
Congratulations on your first microsoft/STL commit! 😺 This will appear in VS 2019 16.8 Preview 1. |
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 25, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 26, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 29, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated variable _MSVC_STL_UPDATE in
STL/stl/inc/yvals_core.h
Line 488 in c64e60b
to fix #895.