Cleanup ranges test machinery #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use helper function `to_bool` to replace function-style casts to `bool`. It's cleaner while still being more concise than a full `static_cast`.
StephanTLavavej
approved these changes
Jun 16, 2020
mnatsuhara
approved these changes
Jun 16, 2020
StephanTLavavej
approved these changes
Jun 16, 2020
Member
|
Thanks for cleaning up these functional-style casts! To celebrate, here are functional-style cats: 😸(😺) |
Contributor
Author
I think you've rediscovered Schrödinger's lambda calculus. |
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 25, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 26, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 29, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jul 1, 2020
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 10, 2020
added test_bidi to range_algo_support removed fill code Cleanup ranges test machinery (microsoft#899) tests: Avoid dialog boxes, prevent stdout from being lost (microsoft#906) Fixes microsoftGH-781 (dialogs) and fixes microsoftGH-789 (stdout). updating tests with bidi_range wrapper fixing tests initial reverse algo removed fill code updating tests with bidi_range wrapper
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 10, 2020
added test_bidi to range_algo_support removed fill code Cleanup ranges test machinery (microsoft#899) tests: Avoid dialog boxes, prevent stdout from being lost (microsoft#906) Fixes microsoftGH-781 (dialogs) and fixes microsoftGH-789 (stdout). updating tests with bidi_range wrapper fixing tests initial reverse algo removed fill code updating tests with bidi_range wrapper Fix bad merge in range_algo_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use helper function
to_boolto replace function-style casts tobool. It's cleaner while still being more concise than a fullstatic_cast.