Internal headers have extension .hpp #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.... except for `__meow.hpp` headers which are normal product headers. Rename `tests/std/include/test_windows.h` to `tests/std/include/test_windows.hpp` to be consistent with this naming policy. Tell clang-format that .hpp headers should be ordered after other headers in a separate block. Roughly per discussion beginning with https://github.com/microsoft/STL/pull/901/files#r441022179.
StephanTLavavej
approved these changes
Jun 17, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Reminder (possibly to self): This will require setup changes in the Microsoft-internal PR.
StephanTLavavej
approved these changes
Jun 18, 2020
mnatsuhara
approved these changes
Jun 22, 2020
StephanTLavavej
approved these changes
Jun 23, 2020
StephanTLavavej
changed the title
Member
|
Thanks for this improvement! Renames are always a headache, but now we don't need to worry about sorting headers in a special order, or remembering that |
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... except for
__meow.hppheaders which are normal product headers. Rename internal.hheaders to.hppto be consistent with this naming policy. Tell clang-format that .hpp headers should be ordered after other headers in a separate block.Roughly per discussion beginning with https://github.com/microsoft/STL/pull/901/files#r441022179.