Implement ranges::generate and ranges::generate_n #905

ahanamuk · 2020-06-17T16:05:08Z

No description provided.

…folder with test

…t copy

Ditto fix merge conflict for Generate

ghost · 2020-06-17T16:05:22Z

All CLA requirements met.

* revert inadvertent change to LLVM reference * update `range_algorithm_support.hpp` from `fill` PR to reduce future merge conflicts

StephanTLavavej · 2020-07-02T02:16:41Z

Oops, got confused about whether I had previously approved this.

stl/inc/algorithm

tests/std/tests/P0896R4_ranges_alg_generate/test.cpp

tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp

tests/std/include/range_algorithm_support.hpp

stl/inc/algorithm

tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp

stl/inc/algorithm

tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp

tests/std/tests/P0896R4_ranges_alg_generate/test.cpp

tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>

tests/std/tests/P0896R4_ranges_alg_generate/test.cpp

StephanTLavavej · 2020-07-11T21:21:40Z

Thanks for implementing these ranges algorithms, they're going to generate a lot of excitement. 😎

miscco · 2020-07-11T21:25:45Z

@CaseyCarter how did you hack into @StephanTLavavej's account?

CaseyCarter · 2020-07-12T02:23:29Z

@CaseyCarter how did you hack into @StephanTLavavej's account?

I had the exact same thought - he's even using the sunglasses emoji instead of cat emoji! I feel seen.

ahanamuk and others added 25 commits June 8, 2020 15:15

added the move algorithm on line 1265 of algorithm and created a new …

19c2a15

…folder with test

added cmake file

354e48b

passing all tests for ranges move algorithm

09f6c9f

updated move algo tests to check that we actually move elems, not jus…

61375a9

…t copy

enabled constexpr, cleaned up move algo test

68640ed

removed iostream unused header

5277552

mainly updated formatting/comments based on feedback

45fb14d

Delete cmake

80e349e

modified a test

d4f91b0

Merge branch 'move_algo' of https://github.com/ahanamuk/STL

a685197

initial fill algo

c9f134f

Passing all fill tests

93ff947

added a test case

be947f1

minor changes/formatting updates to move

5cb7bfc

updated clang formatting

9170077

initial fill algo

d4fbaac

comitting untracked stuff

064684e

generate initial commit

91040f9

minor changes

dd51ae0

Merge branch 'master' into generate_algo

62689da

generate_n tests added

e2c8965

similar changes as casey made in fill_n

cc7220a

Merge pull request #2 from CaseyCarter/generate

f7cf046

Ditto fix merge conflict for Generate

generate and generate_n tests passing now

e61aa5f

minor change

9c8acb3

ahanamuk added the cxx20 C++20 feature label Jun 17, 2020

ahanamuk requested a review from a team as a code owner June 17, 2020 16:05

CaseyCarter mentioned this pull request Jun 17, 2020

P0896R4 <ranges> #39

Closed

mnatsuhara assigned CaseyCarter Jun 17, 2020

tiny fixes:

37b38d9

* revert inadvertent change to LLVM reference * update `range_algorithm_support.hpp` from `fill` PR to reduce future merge conflicts

StephanTLavavej approved these changes Jul 2, 2020

View reviewed changes

StephanTLavavej self-requested a review July 2, 2020 02:16

CaseyCarter approved these changes Jul 2, 2020

View reviewed changes

StephanTLavavej requested changes Jul 2, 2020

View reviewed changes

added test for 0 and -1 for generate_n

a985e79

CaseyCarter approved these changes Jul 7, 2020

View reviewed changes

CaseyCarter requested a review from StephanTLavavej July 7, 2020 20:33

Merge remote-tracking branch 'origin/master' into generate

9756d7b

StephanTLavavej requested changes Jul 8, 2020

View reviewed changes

tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated Show resolved Hide resolved

Review comments; modernize

b2d281a

StephanTLavavej approved these changes Jul 8, 2020

View reviewed changes

stl/inc/algorithm Show resolved Hide resolved

tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Show resolved Hide resolved

StephanTLavavej added the ranges C++20/23 ranges label Jul 8, 2020

Review comments

053cda7

StephanTLavavej requested changes Jul 9, 2020

View reviewed changes

tests/std/tests/P0896R4_ranges_alg_generate/test.cpp Outdated Show resolved Hide resolved

tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated Show resolved Hide resolved

Apply suggestions from code review

40ddeac

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>

CaseyCarter requested a review from StephanTLavavej July 9, 2020 00:17

StephanTLavavej approved these changes Jul 9, 2020

View reviewed changes

CaseyCarter removed their assignment Jul 9, 2020

mnatsuhara reviewed Jul 10, 2020

View reviewed changes

tests/std/tests/P0896R4_ranges_alg_generate/test.cpp Show resolved Hide resolved

Miya's 11th hour save

81b8b70

CaseyCarter approved these changes Jul 10, 2020

View reviewed changes

mnatsuhara mentioned this pull request Jul 10, 2020

Implement ranges::remove family #1005

Merged

StephanTLavavej self-assigned this Jul 10, 2020

StephanTLavavej merged commit ee6019d into microsoft:master Jul 11, 2020

Implement ranges::generate and ranges::generate_n #905

Implement ranges::generate and ranges::generate_n #905

Uh oh!

Conversation

ahanamuk commented Jun 17, 2020

Uh oh!

ghost commented Jun 17, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StephanTLavavej commented Jul 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Jul 11, 2020

Uh oh!

miscco commented Jul 11, 2020

Uh oh!

CaseyCarter commented Jul 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ghost commented Jun 17, 2020 •

edited by ghost

Loading