Implement ranges min/max/minmax algorithms #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `ranges::min` (direct, `range`, and `initializer_list` overloads) * `ranges::max` (direct, `range`, and `initializer_list` overloads) * `ranges::minmax` (direct, `range`, and `initializer_list` overloads) * `ranges::min_element` (`range` only) * `ranges::max_element` (`range` only) * `ranges::minmax_element` (`range` only) * `ranges::clamp` (direct only) Implements concept `indirectly_copyable_storable`, and adds test coverage for both that concept and `indirectly_movable_storable`.
This was referenced Jun 24, 2020
Closed
miscco
reviewed
Jun 24, 2020
StephanTLavavej
changed the title
mnatsuhara
approved these changes
Jun 26, 2020
Contributor
mnatsuhara
left a comment
mnatsuhara
left a comment
There was a problem hiding this comment.
Impressively thorough testing :) I couldn't find much!
StephanTLavavej
requested changes
Jun 27, 2020
StephanTLavavej
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ranges::min(direct,range, andinitializer_listoverloads)ranges::max(direct,range, andinitializer_listoverloads)ranges::minmax(direct,range, andinitializer_listoverloads)ranges::min_element(rangeonly)ranges::max_element(rangeonly)ranges::minmax_element(rangeonly)ranges::clamp(direct only)Implements concept
indirectly_copyable_storable, and adds test coverage for both that concept andindirectly_movable_storable.Partially addresses #39.
(Note: #914, #915, and #916 contain identical changes to
<range_algorithm_support.hpp>.)