Remove invalid overload of ranges::copy_n #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Jul 1, 2020
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Great cleanup. (I'm just completely gobsmacked about the range overload of copy_n. 🤯)
CaseyCarter
suggested changes
Jul 1, 2020
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
CaseyCarter
approved these changes
Jul 9, 2020
East-`const` is best `const`, but `const`-west is de facto. =(
StephanTLavavej
approved these changes
Jul 9, 2020
Member
|
Thanks for finding and fixing this! 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modernizing the tests I found that there is a copy & paste error with a second overload that would not even compile if it was called.
Modernize the tests and remove the invalid overload.
I also changed the default type of the
test_counted_writerange to const int as we generally should avoid modifying the input range.