Skip to content

Modernize ranges::copy_if #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 3 commits into from
Jul 11, 2020
Merged

Modernize ranges::copy_if #958

StephanTLavavej merged 3 commits into from
Jul 11, 2020

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Jul 1, 2020

Use the new way of delegating the work and improve the tests

@miscco miscco requested a review from a team as a code owner July 1, 2020 12:13
@miscco
Copy link
Contributor Author

miscco commented Jul 1, 2020

C:\agent_work\1\s\tests\std\tests\P0896R4_ranges_alg_copy_if\test.cpp(84): fatal error C1060: compiler is out of heap space

Double ups

@BillyONeal we need MOOOOOOOOOORE RAM

CaseyCarter
CaseyCarter suggested changes Jul 1, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej added the cxx20 C++20 feature label Jul 1, 2020
@CaseyCarter CaseyCarter added enhancement Something can be improved and removed cxx20 C++20 feature labels Jul 1, 2020
CaseyCarter
CaseyCarter suggested changes Jul 3, 2020
View reviewed changes
@miscco miscco force-pushed the ranges_copy_if branch 4 times, most recently from 9286de8 to f31a68c Compare July 3, 2020 18:56
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 8, 2020
StephanTLavavej
StephanTLavavej requested changes Jul 10, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll push a change to restore <utility> for move().

@StephanTLavavej StephanTLavavej self-assigned this Jul 10, 2020
@StephanTLavavej StephanTLavavej merged commit 215ec06 into microsoft:master Jul 11, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jul 11, 2020

Thanks for this series of improvements! One might say that this is a total copycat of #956. 🐈

@miscco miscco deleted the ranges_copy_if branch July 12, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miscco @StephanTLavavej @CaseyCarter