Skip to content

Modernize ranges::count_if #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 3 commits into from
Jul 11, 2020
Merged

Modernize ranges::count_if #975

StephanTLavavej merged 3 commits into from
Jul 11, 2020

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Jul 2, 2020

This does even compile as it does not need the new machinery

@miscco miscco requested a review from a team as a code owner July 2, 2020 19:29
CaseyCarter
CaseyCarter suggested changes Jul 2, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jul 3, 2020
@miscco miscco force-pushed the ranges_count_if branch from c0d1772 to 757db1b Compare July 3, 2020 05:10
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 8, 2020
@StephanTLavavej StephanTLavavej self-assigned this Jul 10, 2020
@StephanTLavavej StephanTLavavej merged commit 672bcb2 into microsoft:master Jul 11, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jul 11, 2020

ranges::count_if(pull_requests, is_awesome) seems to behave the same as ranges::count(pull_requests). There must be a bug somewhere.

@miscco miscco deleted the ranges_count_if branch July 12, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miscco @StephanTLavavej @CaseyCarter