Skip to content

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Jul 3, 2020

We get errors due to ambiguous symbols of test::iterator and std::iterator (thanks using namespace std;)
Explicitely pull in test::iterator and test::range for good measure too

@miscco miscco requested a review from a team as a code owner July 3, 2020 08:15
@StephanTLavavej
Copy link
Member

I have traditionally preferred to name test machinery differently than Standard machinery to avoid any potential for ambiguity (as I've been a huge fan of using namespace std; in tests); MeowIterator and to a slightly lesser extent meow_iterator are clearly non-Standard. That said, I certainly defer to @CaseyCarter on ranges test conventions.

@StephanTLavavej StephanTLavavej added the test Related to test code label Jul 3, 2020
@CaseyCarter CaseyCarter self-assigned this Jul 7, 2020
@CaseyCarter CaseyCarter merged commit ed5698b into microsoft:master Jul 7, 2020
@CaseyCarter
Copy link
Contributor

Thanks for the cleanup, @miscco!

@miscco miscco deleted the fix_tests branch July 7, 2020 21:29
@CaseyCarter CaseyCarter removed their assignment Jul 7, 2020
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ranges C++20/23 ranges test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants