Update _MSVC_STL_UPDATE for July 2020 #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Jul 4, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Yay! Welcome to open source! 😸
We should be able to merge this early next week (our process requires two maintainers to review and approve, then a maintainer needs to port the change to our Microsoft-internal repository simultaneously - which is hilariously excessive for an obviously correct single-line change, but more appropriate for the larger changes we usually merge).
CaseyCarter
approved these changes
Jul 5, 2020
CaseyCarter
changed the title
Contributor
|
Congratulations on your first STL contribution! 🎉 |
CaseyCarter
added
fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
#define _MSVC_STL_UPDATE 202006L
to
#define _MSVC_STL_UPDATE 202007L
Thank you so much for creating this issue for us (newcomers and beginners).