Implement ranges::replace_copy_if #998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Jul 5, 2020
|
|
||
| auto result = replace_copy_if( | ||
| wrapped_input.begin(), wrapped_input.end(), Write{output}, matches, P{47, 1}, get_second); | ||
| STATIC_ASSERT(same_as<decltype(result), replace_copy_if_result<iterator_t<Read>, Write>>); |
Contributor
There was a problem hiding this comment.
Suggested change
| STATIC_ASSERT(same_as<decltype(result), replace_copy_if_result<iterator_t<Read>, Write>>); | |
| STATIC_ASSERT(same_as<decltype(result), replace_copy_if_result<ranges::iterator_t<Read>, Write>>); | |
(And on 46.)
Contributor
Author
There was a problem hiding this comment.
I changed it to using declarations as in the other tests
Contributor
Author
|
Narf, I should really take thetime to read everything a second Time if I do not expect it to compileanyway. Sorry for the noise |
StephanTLavavej
requested changes
Jul 6, 2020
| template <class _It, class _Se, class _Ty, class _Out, class _Pj, class _Pr> | ||
| _NODISCARD static constexpr replace_copy_if_result<_It, _Out> _Replace_copy_if_unchecked( | ||
| _It _First, const _Se _Last, _Out _Result, _Pr _Pred, const _Ty& _Newval, _Pj _Proj) { | ||
| // copy [_First, _Last) to _Out while replacing _Oldval with _Newval if projected _Oldval fulfuills _Pred |
Member
There was a problem hiding this comment.
Typo, and _Out is a type while _Result is a variable:
Suggested change
| // copy [_First, _Last) to _Out while replacing _Oldval with _Newval if projected _Oldval fulfuills _Pred | |
| // copy [_First, _Last) to _Result while replacing _Oldval with _Newval if projected _Oldval fulfills _Pred |
Closed
Contributor
Author
|
Dropping in favor of #983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements ranges::replace_copy_if
There is still the compile error wrt
indirect_copyablesame as forreplace_copy