Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Workaround] CNTKModel does not output correct result #1076

Merged
merged 3 commits into from
Jun 9, 2021
Merged

fix: [Workaround] CNTKModel does not output correct result #1076

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0110b03
fix: [Workaround] CNTKModel does not output correct result for ResNet…
memoryz Jun 8, 2021
dc69f76
Add code comment to reference issue 1075
memoryz Jun 8, 2021
9f5b024
Only cache for non-streaming df
memoryz Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/scala/com/microsoft/ml/spark/cntk/CNTKModel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,10 @@ class CNTKModel(override val uid: String) extends Model[CNTKModel] with ComplexP
val droppedDF = outputDF.drop(outputDF.columns.filter(_.startsWith(coercionPrefix)): _*)

val unbatchedDF = if (getBatchInput) {
new FlattenBatch().transform(droppedDF)
// TODO: The cache call is a workaround for issue 1075:
// https://github.com/Azure/mmlspark/issues/1075
val cacheAttempted = if (droppedDF.isStreaming) droppedDF else droppedDF.cache()
new FlattenBatch().transform(cacheAttempted)
} else {
droppedDF
}
Expand Down