feat: Global Param Object #2306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tName added to GlobalParam set
mhamilton723
reviewed
Nov 4, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 4, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 4, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 4, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 4, 2024
| } | ||
| } | ||
|
|
||
| def getGlobalServiceParamVector[T](p: ServiceParam[T]): T= { //TODO: should return a string |
There was a problem hiding this comment.
this perhaps should return String as it should be asking about the other side of the service param the name of the column
mhamilton723
reviewed
Nov 4, 2024
cognitive/src/test/scala/com/microsoft/azure/synapse/ml/services/openai/GlobalParamSuite.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 4, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 7, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 7, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 7, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/GlobalParam.scala
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Nov 7, 2024
cognitive/src/test/scala/com/microsoft/azure/synapse/ml/services/GlobalParamSuite.scala
Outdated
Show resolved
Hide resolved
…sserts to type check Params vs Service Params. Added more tests. Tests pass!
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/GlobalParam.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/GlobalParam.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Adding a GlobalParamObject allowing users to set fields like "DeploymentName" only once and for it to be used everywhere.
Introduces HasGlobalParams, containing getters for these new Global Params.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.