Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightGBMRegressor.py : updating imports #940

Closed
wants to merge 3 commits into from
Closed

LightGBMRegressor.py : updating imports #940

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 21, 2020

SparkContext was imported twice. Also SQLContext is outdated, and was not used anyways
... or did I miss something ?

SparkContext was imported twice. Also SQLContext is outdated, and was not used anyways
@ghost ghost requested a review from imatiach-msft as a code owner October 21, 2020 10:21
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imatiach-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@imatiach-msft imatiach-msft changed the title LightGBMRegressor.py : updating imports fix: LightGBMRegressor.py : updating imports Oct 22, 2020
@imatiach-msft imatiach-msft changed the title fix: LightGBMRegressor.py : updating imports LightGBMRegressor.py : updating imports Oct 22, 2020
@imatiach-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mhamilton723
Copy link
Collaborator

@imatiach-msft sorry for the pain had to reconf the build as azure devops had an outage that broke us

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #940 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   84.93%   85.13%   +0.19%     
==========================================
  Files         193      193              
  Lines        9039     9039              
  Branches      568      568              
==========================================
+ Hits         7677     7695      +18     
+ Misses       1362     1344      -18     
Impacted Files Coverage Δ
...oft/ml/spark/vw/VowpalWabbitContextualBandit.scala 89.61% <0.00%> (+1.29%) ⬆️
...om/microsoft/ml/spark/featurize/ValueIndexer.scala 77.61% <0.00%> (+1.49%) ⬆️
...soft/ml/spark/cognitive/CognitiveServiceBase.scala 84.74% <0.00%> (+1.69%) ⬆️
...com/microsoft/ml/spark/core/contracts/Params.scala 95.74% <0.00%> (+2.12%) ⬆️
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 60.71% <0.00%> (+3.57%) ⬆️
.../microsoft/ml/spark/core/schema/Categoricals.scala 86.45% <0.00%> (+4.16%) ⬆️
...ain/scala/com/microsoft/ml/spark/nn/BallTree.scala 87.61% <0.00%> (+4.76%) ⬆️
...n/scala/org/apache/spark/ml/param/ArrayParam.scala 70.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a30d1a...b571350. Read the comment docs.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor

closing as this issue has been fixed in PR:
#758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants