Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to compute game's walkthrough if it was not store in the metadata. #225

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

MarcCote
Copy link
Contributor

This PR adds the Game.walkthrough property. It first looks for a walkthrough stored in the metadata, otherwise, it tries to derive one from Game.quests. It will return None if it can find any walkthroughs.

Fixes #224

@codecov-io
Copy link

Codecov Report

Merging #225 into master will decrease coverage by 0.1%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   82.97%   82.86%   -0.11%     
==========================================
  Files          56       56              
  Lines        6930     6941      +11     
==========================================
+ Hits         5750     5752       +2     
- Misses       1180     1189       +9
Impacted Files Coverage Δ
textworld/generator/game.py 94.52% <18.18%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3dd71f...0db24f8. Read the comment docs.

@MarcCote MarcCote merged commit 93a22cf into microsoft:master Mar 10, 2020
@MarcCote MarcCote deleted the fix_224 branch March 10, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tw-extract walkthroughs creating empty file
2 participants