Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event types of XMLHttpRequest #110

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions baselines/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13134,7 +13134,7 @@ declare var XMLDocument: {

interface XMLHttpRequest extends EventTarget, XMLHttpRequestEventTarget {
msCaching: string;
onreadystatechange: (ev: ProgressEvent) => any;
onreadystatechange: (ev: Event) => any;
readonly readyState: number;
readonly response: any;
readonly responseText: string;
Expand All @@ -13160,14 +13160,14 @@ interface XMLHttpRequest extends EventTarget, XMLHttpRequestEventTarget {
readonly LOADING: number;
readonly OPENED: number;
readonly UNSENT: number;
addEventListener(type: "abort", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ErrorEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "readystatechange", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "progress", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "readystatechange", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "abort", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "timeout", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
}

Expand Down Expand Up @@ -13606,20 +13606,20 @@ interface WindowTimersExtension {
}

interface XMLHttpRequestEventTarget {
onabort: (ev: Event) => any;
onerror: (ev: Event) => any;
onload: (ev: Event) => any;
onabort: (ev: ProgressEvent) => any;
onerror: (ev: ProgressEvent) => any;
onload: (ev: ProgressEvent) => any;
onloadend: (ev: ProgressEvent) => any;
onloadstart: (ev: Event) => any;
onloadstart: (ev: ProgressEvent) => any;
onprogress: (ev: ProgressEvent) => any;
ontimeout: (ev: ProgressEvent) => any;
addEventListener(type: "abort", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ErrorEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "progress", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "abort", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "timeout", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
}

Expand Down
36 changes: 18 additions & 18 deletions baselines/webworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ declare var Worker: {

interface XMLHttpRequest extends EventTarget, XMLHttpRequestEventTarget {
msCaching: string;
onreadystatechange: (ev: ProgressEvent) => any;
onreadystatechange: (ev: Event) => any;
readonly readyState: number;
readonly response: any;
readonly responseText: string;
Expand All @@ -734,14 +734,14 @@ interface XMLHttpRequest extends EventTarget, XMLHttpRequestEventTarget {
readonly LOADING: number;
readonly OPENED: number;
readonly UNSENT: number;
addEventListener(type: "abort", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ErrorEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "readystatechange", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "progress", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "readystatechange", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "abort", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "timeout", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
}

Expand Down Expand Up @@ -772,23 +772,23 @@ interface AbstractWorker {
}

interface MSBaseReader {
onabort: (ev: Event) => any;
onerror: (ev: Event) => any;
onload: (ev: Event) => any;
onabort: (ev: ProgressEvent) => any;
onerror: (ev: ProgressEvent) => any;
onload: (ev: ProgressEvent) => any;
onloadend: (ev: ProgressEvent) => any;
onloadstart: (ev: Event) => any;
onloadstart: (ev: ProgressEvent) => any;
onprogress: (ev: ProgressEvent) => any;
readonly readyState: number;
readonly result: any;
abort(): void;
readonly DONE: number;
readonly EMPTY: number;
readonly LOADING: number;
addEventListener(type: "abort", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ErrorEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "abort", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "progress", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
}
Expand Down Expand Up @@ -825,13 +825,13 @@ interface XMLHttpRequestEventTarget {
onloadstart: (ev: Event) => any;
onprogress: (ev: ProgressEvent) => any;
ontimeout: (ev: ProgressEvent) => any;
addEventListener(type: "loadstart", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "progress", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "abort", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "error", listener: (ev: ErrorEvent) => any, useCapture?: boolean): void;
addEventListener(type: "load", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadstart", listener: (ev: Event) => any, useCapture?: boolean): void;
addEventListener(type: "progress", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "timeout", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: "loadend", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
}

Expand Down
77 changes: 75 additions & 2 deletions inputfiles/overridingTypes.json
Original file line number Diff line number Diff line change
Expand Up @@ -792,5 +792,78 @@
"setTimeout(handler: any, timeout?: any, ...args: any[]): number",
"setTimeout(handler: (...args: any[]) => void, timeout: number): number"
]
}
]
},
{
"kind": "property",
"interface": "XMLHttpRequest",
"name": "onreadystatechange",
"type": "(ev: Event) => any"
},
{
"kind": "property",
"interface": "XMLHttpRequestEventTarget",
"name": "onabort",
"type": "(ev: ProgressEvent) => any"
},
{
"kind": "property",
"interface": "XMLHttpRequestEventTarget",
"name": "onerror",
"type": "(ev: ProgressEvent) => any"
},
{
"kind": "property",
"interface": "XMLHttpRequestEventTarget",
"name": "ontimeout",
"type": "(ev: ProgressEvent) => any"
},
{
"kind": "property",
"interface": "XMLHttpRequestEventTarget",
"name": "onloadstart",
"type": "(ev: ProgressEvent) => any"
},
{
"kind": "property",
"interface": "XMLHttpRequestEventTarget",
"name": "onload",
"type": "(ev: ProgressEvent) => any"
},
{
"kind": "property",
"interface": "XMLHttpRequestEventTarget",
"name": "onloadend",
"type": "(ev: ProgressEvent) => any"
},
{
"kind": "method",
"interface": "XMLHttpRequest",
"name": "addEventListener",
"signatures": [
"addEventListener(type: \"readystatechange\", listener: (ev: Event) => any, useCapture?: boolean): void",
"addEventListener(type: \"loadstart\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"progress\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"abort\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"error\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"load\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"timeout\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"loadend\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void"
]
},
{
"kind": "method",
"interface": "XMLHttpRequestEventTarget",
"name": "addEventListener",
"signatures": [
"addEventListener(type: \"loadstart\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"progress\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"abort\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"error\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"load\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"timeout\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: \"loadend\", listener: (ev: ProgressEvent) => any, useCapture?: boolean): void",
"addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void"
]
}
]