Add async iterable flavors #1135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Hmm, I'd accept this after anyone actually implement that. For now I guess no real value is there. |
|
Uhhh, yeah, I just realized there are currently 0 browser implementations of I'll try again next year or something. 😛 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
async iterabledeclarations per Web IDL, and emit them as.asynciterable.d.tsflavors. This is an alternative solution for #1134, and a first step towards microsoft/TypeScript#29867.Since this is currently only used by a single interface (
ReadableStream), I understand that there's limited use for this. That's why I'm opening this as a draft PR for now: as a proof-of-concept on what this could look like, and as a starting point to discuss if we want to proceed with this. (If we don't want this, that's fine too, no hard feelings. 🙂)