Add typings for custom elements v1 API #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rictic, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
👍 |
rictic
force-pushed
the
customElements
branch
from
b6dd002 to
e3002ee
Compare
|
Sure thing, rebased! |
Source: https://www.w3.org/TR/2016/WD-custom-elements-20160830/ As suggested by comments on Polymer/polymer#3954
rictic
force-pushed
the
customElements
branch
from
e3002ee to
2692b2e
Compare
|
Rebased again! |
|
Hm, looks like it was failing due to the use of |
rictic
force-pushed
the
customElements
branch
from
837420b to
2b2fd67
Compare
|
Erp, hadn't updated the baseline. Amended that commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source: https://www.w3.org/TR/2016/WD-custom-elements-20160830/
As suggested by comments on Polymer/polymer#3954