Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core dependencies #1561

Merged
merged 1 commit into from
May 12, 2023

Conversation

typescript-bot
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 1bfe721 into microsoft:main May 12, 2023
@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented May 12, 2023

Is that correct?
I can not test this right now but BCD or MDN do not mention this second parameters.

Edit:
Ref
whatwg/url#735

Only webkit has an implementation since a few dayr, but nothing shipped

@saschanaz
Copy link
Contributor

saschanaz commented May 12, 2023

Yeah technically I should wait for another implementation, but I can also just go implement it in Gecko very soon, so I just decided to land it for this one. (Because this is a simple addition)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants