Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lack of undefined for DOMStringMap indexer #190

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

Pinpickle
Copy link
Contributor

Fixes: microsoft/TypeScript#13792

Currently, the DOMStringMap interface doesn't respect that elements in the map may be undefined. This makes it easy to result in type errors around its usage.

This PR adds a union with the undefined type to the elements in order to accurately reflect its possible runtime types.

@msftclas
Copy link

msftclas commented Feb 1, 2017

Hi @Pinpickle, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftgits
Copy link

msftgits commented Feb 1, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Feb 1, 2017
@msftgits msftgits reopened this Feb 1, 2017
@msftclas
Copy link

msftclas commented Feb 1, 2017

Hi @Pinpickle, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@zhengbli
Copy link
Contributor

zhengbli commented Feb 2, 2017

👍

@zhengbli zhengbli merged commit 62c5f36 into microsoft:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants