-
Notifications
You must be signed in to change notification settings - Fork 441
Add more comments #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more comments #1993
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm yet to review this, but please do not convert to sync APIs.
Sure |
Hello @saschanaz |
I have updated the context to not call the API in the emitter, but that cause the test to fail, I will fix it later |
Done @saschanaz |
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
LGTM 🎉 |
There was an issue merging, maybe try again saschanaz. Details |
Thank you very much @saschanaz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this, there's nothing else to comment on, right? This is as large as we're going to get?
Each one of these makes parsing the DOM types slower, so I'm hoping that we stop at some point 😅
Technically we still have events, but adding comments there would be a bit awkward as that would only work for |
LGTM |
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Hello @jakebailey |
I don't know what you mean, sorry. The comments have to be in a declaration file. Moving them elsewhere won't speed things up (and will make the compiler/editor stuff challenging). |
I mean instead of fetching the data each time you run the generate command, we can put the comments in a json file and the builder will use that json file instead of fetching the summaries every time |
I am pretty sure Jake meant the usage (in the editor and compile of user code) of the generated files will slow down the typescript compiler as it has to parse more data. |
related to #1940
Hello:)
In my last PR I have used MDN to generate comments for interface declarations, in this pr I add it for the properties.