Skip to content

Migrate payment related interfaces & Support Interface rename #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2025
+12 −25
Merged

Migrate payment related interfaces & Support Interface rename #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92bb2aa
Payments
Bashamega Nov 3, 2025
8c3cffb
Rename interfaces
Bashamega Nov 3, 2025
8b9ed32
Add payment-request.kdl file
Bashamega Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3315,9 +3315,6 @@
}
}
},
"ContactAddress": {
"name": "PaymentAddress"
},
"HTMLMediaElement": {
"properties": {
"property": {
Expand Down Expand Up @@ -3364,27 +3361,6 @@
"exposed": "Window"
},

// Payment Request added shippingAddress with a different type
// https://github.com/w3c/payment-request/pull/996
"PaymentRequest": {
"properties": {
"property": {
"shippingAddress": {
"type": "PaymentAddress"
}
}
}
},
"PaymentResponse": {
"properties": {
"property": {
"shippingAddress": {
"type": "PaymentAddress"
}
}
}
},

"SourceBuffer": {
"exposed": "Window"
},
Expand Down
11 changes: 11 additions & 0 deletions inputfiles/patches/payment-request.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Payment Request added shippingAddress with a different type
// https://github.com/w3c/payment-request/pull/996
Copy link
Contributor

@saschanaz saschanaz Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

payment-request.kdl per the spec name?

Copy link
Contributor Author

@Bashamega Bashamega Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


interface ContactAddress name=PaymentAddress

interface PaymentRequest {
property shippingAddress type=PaymentAddress
}
interface PaymentResponse {
property shippingAddress type=PaymentAddress
}
2 changes: 1 addition & 1 deletion src/build/patches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ function handleMixinandInterfaces(
node: Node,
type: "mixin" | "interface",
): DeepPartial<Interface> {
const name = node.values[0];
const name = string(node.properties?.name || node.values[0]);

const event: Event[] = [];
const property: Record<string, Partial<Property>> = {};
Expand Down