-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebIDL typedefs by json #338
Conversation
b3175c7
to
0167840
Compare
df1178f
to
4a784fd
Compare
@saschanaz with #383 in, can you update the change to merge in the .json file |
Does that mean we want to merge into the existing We may just get Web IDL files directly in this repo and use them. |
No, i meant like we are doing with the override and added types, just like: https://github.com/Microsoft/TSJS-lib-generator/blob/master/src/index.ts#L91-L94. My concern is to have a way to know what changed easily to avoid breaking changes. So what i am suggesting is to add the webidl files one at a time, merge the new webidl file with the existing definitions and generate the output, this way we have an easy way to see what changed, then remove the current browser.idl file at the end. |
That will be great. So, my current plan is put |
sounds great, and sorry again for the delay. |
See #405 if anyone has subscribed this 😁 |
This is a subset of #300.
This fixes some unexpected
any
types by correctly introducing WebIDL basic types.NOTE: If you as a reviewer think this PR is still too big to review in your free time, please tell me and I will split this PR once more. Any feedback will be much appreciated.