Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebIDL typedefs by json #338

Closed
wants to merge 4 commits into from

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Dec 3, 2017

This is a subset of #300.

This fixes some unexpected any types by correctly introducing WebIDL basic types.

NOTE: If you as a reviewer think this PR is still too big to review in your free time, please tell me and I will split this PR once more. Any feedback will be much appreciated.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 7, 2018

@saschanaz with #383 in, can you update the change to merge in the .json file

@saschanaz
Copy link
Contributor Author

saschanaz commented Mar 8, 2018

to merge in the .json file

Does that mean we want to merge into the existing browser.webidl.preprocessed.json file?

We may just get Web IDL files directly in this repo and use them.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 8, 2018

Does that mean we want to merge into the existing browser.webidl.preprocessed.json file?

No, i meant like we are doing with the override and added types, just like: https://github.com/Microsoft/TSJS-lib-generator/blob/master/src/index.ts#L91-L94.

My concern is to have a way to know what changed easily to avoid breaking changes. So what i am suggesting is to add the webidl files one at a time, merge the new webidl file with the existing definitions and generate the output, this way we have an easy way to see what changed, then remove the current browser.idl file at the end.

@saschanaz
Copy link
Contributor Author

That will be great. So, my current plan is put inputfiles/idl/${spec name}.widl, write an WIDL-to-JSON converter module (using webidl2.js package), and then merge them into the existing definitions. Sounds good?

@mhegazy
Copy link
Contributor

mhegazy commented Mar 8, 2018

sounds great, and sorry again for the delay.

@saschanaz
Copy link
Contributor Author

See #405 if anyone has subscribed this 😁

@saschanaz saschanaz closed this Apr 6, 2018
@saschanaz saschanaz deleted the webidl-types branch April 6, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants