Fix lib breaks #560
Merged
Fix lib breaks #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though not part of the current spec, browsers do support the additonal property
This was referenced Aug 2, 2018
|
@mhegazy Can we mark the deprecated argument of createTreeWalker as deprecated? Also |
saschanaz
reviewed
Aug 3, 2018
| @@ -9282,7 +9282,7 @@ interface Location { | |||
| /** | |||
| * Reloads the current page. | |||
| */ | |||
| reload(): void; | |||
| reload(forcedReload?: boolean): void; | |||
There was a problem hiding this comment.
Not browser"s" because its Firefox specific. https://bugzilla.mozilla.org/show_bug.cgi?id=1037721
Not in current Chromium: https://chromium.googlesource.com/chromium/blink/+/master/Source/core/frame/Location.idl
There was a problem hiding this comment.
We can change it to two overloads and mark it as deprecated.
sounds like a good idea. |
This was referenced Aug 3, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a set of issues that were identified by our real world code test suits.