Skip to content

Add missing HTML tags #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Add missing HTML tags #609

merged 1 commit into from
Jan 24, 2019

Conversation

saschanaz
Copy link
Contributor

@falsandtru
Copy link
Contributor

@sandersn Merge this plz. I need this patch.

@sandersn sandersn merged commit 3162de4 into microsoft:master Jan 24, 2019
@inad9300
Copy link

It's not too bad to merge this... since it is an improvement. But it is not yet close to fixing microsoft/TypeScript#17828:

  • The HTML elements details and dialog haven't been included.
  • The new HTML interfaces added by @arjunyel (HTMLMainElement, HTMLDetailsElement, etc.), as mentioned in the comments, have been ignored.
  • The SVG elements mentioned in the comments (a, script, style, and title) haven't been considered.

In my opinion, these changes should be reverted until every point is tackled, or else it will be extra work to verify what is and what isn't done.

@saschanaz saschanaz deleted the html-tags branch January 26, 2019 10:06
@saschanaz
Copy link
Contributor Author

saschanaz commented Jan 26, 2019

Hi @inad9300, those HTML tags are covered by other PRs and included in master branch: https://raw.githubusercontent.com/Microsoft/TSJS-lib-generator/master/baselines/dom.generated.d.ts

The SVG elements issue is related with #582 (comment). We currently can't add them because of the blocker.

@inad9300
Copy link

inad9300 commented Feb 3, 2019

Hi @saschanaz. Thanks for following up this issue and for finally resolving the problem with ElementTagNameMap. Nevertheless, please do use the more specific interfaces for the newly added elements, such as HTMLMainElement and the others.

@saschanaz
Copy link
Contributor Author

saschanaz commented Feb 3, 2019 via email

@inad9300
Copy link

inad9300 commented Feb 3, 2019

Great then! Sorry for the inconvenience caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants