Add interface SVGFEDropShadowElement #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
reviewed
Mar 16, 2019
inputfiles/addedTypes.json
Outdated
| } | ||
| } | ||
| }, | ||
| "extends": "SVGElement" |
Contributor
There was a problem hiding this comment.
"implements": ["SVGFilterPrimitiveStandardAttributes"]
is also needed.
Contributor
Author
There was a problem hiding this comment.
Thanks, just did it and pushed the new commit!
Contributor
Author
|
@RyanCavanaugh just noticed you were tagged in the issue (microsoft/TypeScript#29966), but not here! Could you please check this one, it should be ready to merge IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interface
SVGFEDropShadowElementaccording to spec as requested in microsoft/TypeScript#29966.Apparently the interface would have to extend also
SVGFilterPrimitiveStandardAttributes, but I noticed that the spec of the latter doesn't provide any method, sosetStdDeviationwas manually added.How does it look? Any thoughts?