Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Streams to spec version 46c3b89 #669

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Update Streams to spec version 46c3b89 #669

merged 2 commits into from
Apr 3, 2019

Conversation

MattiasBuelens
Copy link
Contributor

This updates the type definitions for Streams to spec version 46c3b89 of 7 November 2018 (spec text).

  • PipeOptions now takes an optional AbortSignal, to allow aborting an ongoing pipe operation started with ReadableStream.pipeTo() or .pipeThrough()

This also removes the (accidentally exposed) ReadableStreamBYOBReader constructor. The spec defines that this constructor should not be exposed.

@MattiasBuelens
Copy link
Contributor Author

There's a newer version of the spec (bf2cac8 of 6 February 2018) that adds async iterable support to ReadableStream. However, this depends on microsoft/TypeScript#29867 to allow defining async iterable DOM types. That's why I'm already opening this pull request for this (slightly) older version.

@sandersn sandersn merged commit 5831c2d into microsoft:master Apr 3, 2019
@MattiasBuelens MattiasBuelens deleted the streams-46c3b89 branch August 27, 2019 11:55
@MattiasBuelens MattiasBuelens mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattiasBuelens @sandersn