Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit toString() #754

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Add explicit toString() #754

merged 3 commits into from
Nov 14, 2019

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Sep 13, 2019 •
edited
Loading

Fixes the lib.dom.d.ts part of microsoft/TypeScript#30225 (comment).

This provides autocomplete for types with their own toString() implementation (as toString() inherited from Object is shadowed by default), and also helps third-party tools that depends on TS type library.

const matrix = new DOMMatrix();
matrix.to // should now autocomplete `toString`

cc @domenic

(This restores cpx removed in #753, as it broke npm run baseline-accept.)

@sandersn sandersn merged commit 288facf into microsoft:master Nov 14, 2019
@derekxu16 derekxu16 mentioned this pull request Nov 22, 2019
Closed
@saschanaz saschanaz deleted the stringifier branch November 22, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @sandersn