Add HTML Web workers types #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Dec 31, 2019
|
Not sure what's going on with the new ExtendableMessageEvent after merging from master. It seems like there are some new diff lines in the last commit that weren't there before. |
sandersn
requested changes
Dec 31, 2019
There was a problem hiding this comment.
I can't figure out where the ExtendableMessageEvent changes came from, and I'm afraid to merge without understanding the difference between it and MessageEvent. @saschanaz do you know what the difference is?
The code currently guesses event interface from other types ( |
orta
approved these changes
Mar 4, 2020
sandersn
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #807