Skip to content

adding new ServiceWorkerEvent interface to allow new event target #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding new ServiceWorkerEvent interface to allow new event target #923

wants to merge 1 commit into from

Conversation

sarahzhao25
Copy link

@sarahzhao25 sarahzhao25 commented Oct 1, 2020 •
edited by sandersn
Loading

Addresses Issue microsoft/TypeScript#40153.

  • created new interface ServiceWorkerEvent
  • trying to edit ServiceWorkerEventMap's statechange property type.

@sarahzhao25 sarahzhao25 requested a review from sandersn as a code owner October 1, 2020 22:29
@ghost
Copy link

ghost commented Oct 1, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@sandersn
Copy link
Member

Sorry I missed this earlier. Can you please run npm test followed by npm run baseline-accept and then check in the updated files? That's why the CI tests failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahzhao25 @sandersn