feat: add serviceworker and sharedworker libs #997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @jakearchibald and @MattiasBuelens |
| outputFolder, | ||
| }); | ||
| emitFlavor(webidl, new Set(knownTypes.Worker), { | ||
| name: "webworker", | ||
| flavor: Flavor.Worker, | ||
| global: "Worker", | ||
| global: ["Worker", "DedicatedWorker", "SharedWorker", "ServiceWorker"], |
There was a problem hiding this comment.
Should we have a new dedicatedworker flavor that only contains ["DedicatedWorker", "Worker"]? It would be nice if you're writing code for a dedicated worker to have the type checker disallow using service worker-only or shared worker-only APIs. But I can also understand that it may be difficult to teach users the difference between the "webworker" and "dedicatedworker" flavors.
There was a problem hiding this comment.
Sounds good to me and it was my initial plan. In the ideal world we could ultimately deprecate webworker in that case. I wonder what the maintainers think.
|
Replaced by #1034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #675, closes #505