Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Confusion around files exclude include filesGlob #334

Closed
basarat opened this issue Jul 4, 2016 · 2 comments
Closed

Confusion around files exclude include filesGlob #334

basarat opened this issue Jul 4, 2016 · 2 comments

Comments

@basarat
Copy link

basarat commented Jul 4, 2016

Docs

This section needs better docs : https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/tsconfig.json.md#details only mentions files / include.

Question

Also does include / exclude support globs? According to http://json.schemastore.org/tsconfig they do. I thought they were just folders & files. Am I wrong?

Suggestion

Perhaps we can remove all files / exclude / include and just filesGlob (big breaking change I know).

Thanks 🌹

@mhegazy
Copy link
Contributor

mhegazy commented Jul 4, 2016

Also does include / exclude support globs? According to http://json.schemastore.org/tsconfig they do. I thought they were just folders & files. Am I wrong?

they did.
include is a new entry added in TS 2.0; both include and exclude now support glob patterns. that was merged in a few weeks back, see microsoft/TypeScript#5980

This section needs better docs : https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/tsconfig.json.md#details only mentions files / include.

The updated documentation is currently in branch release-2.0 and not in master. we will be merging this into master next week. so give the updated page a look at let us know if you believe it still needs updates: https://github.com/Microsoft/TypeScript-Handbook/blob/release-2.0/pages/tsconfig.json.md

Perhaps we can remove all files / exclude / include and just filesGlob (big breaking change I know).

I do not think we intend to support "fileGlobs".

@basarat
Copy link
Author

basarat commented Jul 4, 2016

Awesome. I realized my misunderstanding 🌹

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants