This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
3.7 Release Notes - fix typo #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this sample comparing to type predicates:
```typescript
if (isString(str)) {
return str.toUppercase();
}
```
I believe you meant to put the correct method `str.toUpperCase();`
|
|
|
Hi - this is going into a branch which isn't master, and so it won't get applied to the main repo! If you switch the PR's base branch to master then it'd probably be good to merge 👍 |
3imed-jaberi
approved these changes
Jan 17, 2020
|
perfect, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this sample comparing to type predicates:
I believe you meant to put the correct method
str.toUpperCase();Fixes # 1276