Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting broken following ES6 spread operator #393

Closed
mjbvz opened this issue Dec 29, 2016 · 6 comments
Closed

Syntax highlighting broken following ES6 spread operator #393

mjbvz opened this issue Dec 29, 2016 · 6 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 29, 2016

From @jamietre on December 29, 2016 14:58

  • VSCode Version: 1.9.0-insider commit 9486b4
  • OS Version: Windows 10

Steps to Reproduce:

  1. Create an ES6 class using extends and add super(...args)
  2. Observe lack of highlighting after super(...args)
  3. Profit

Just noticed it this morning on insider build.

Update - affects any use of spread operator

image

Copied from original issue: microsoft/vscode#17905

@ghost
Copy link

ghost commented Jan 4, 2017

While it works with the above example now, it still breaks for me in the simpler case:

const a = Math.max(...x);
const b = 2;

const b = 2; (and the entire rest of the file) is not highlighted at all.
However, it works if I write math.max instead.

@sheetalkamat
Copy link
Member

sheetalkamat commented Jan 4, 2017

Closing this as it is little bit different from the original issue and its easier to track that way. Filed #397

@jamietre
Copy link

jamietre commented Jan 9, 2017

Confused about the status here. This is still broken in today's VS Code insider build, there don't seem to be any open issues addressing it.

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 9, 2017

@jamietre To test the fix, please try installing the Latest TypeScript and Javascript Grammar extension

@jamietre
Copy link

jamietre commented Jan 9, 2017

Beautiful, thanks! I'm a bit confused about the relationship between the VS Code insider build and dependencies such as this, e.g. why would the bug have manifested without my intervention in an insider build, but the fix did not?

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 9, 2017

VSCode insiders contains the latest build for VSCode itself . For dependencies like this, the insiders build picks up the version listed in the package.json, which may not be the latest published version. So to pick up a new version of the TS/JS grammar, we still have to update VSCode to pick up the latest release of this project.

The Latest TS Grammar extension offers an even more up to date version of the TS and JS grammar for testing. It can be installed in older, non-insiders VSCode releases as well and is updated like a normal extension.

Hope that clear things up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants