Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting breaks without any reason. (Javascript) #403

Closed
mjbvz opened this issue Jan 10, 2017 · 12 comments
Closed

Syntax highlighting breaks without any reason. (Javascript) #403

mjbvz opened this issue Jan 10, 2017 · 12 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jan 10, 2017

From @ebastuart on August 24, 2016 8:41

  • VSCode Version: 1.4.0
  • OS Version: Windows 10 64bit, latest updates

the highlighting breaks without any reason. there are no errors and the code is valid, but the code remains white (no highlighting) down to the end of the file.

image

Copied from original issue: microsoft/vscode#10878

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @wallverb on August 24, 2016 18:30

Maybe related to this microsoft/vscode#9937

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @alexandrudima on August 25, 2016 14:22

@ebastuart Is it possible to share the file with us so we can track down the problem and check if it is an issue with the grammar

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @alallier on October 4, 2016 16:1

I've seen this happen in many different occurrences, mainly in longer files. Could this be a file length issue?

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @alexandrudima on October 6, 2016 13:27

@alallier When you notice this, please create an issue and attach the file or a similar file that reproduces the issue.

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @ebastuart on October 6, 2016 13:49

@alallier it is a nesting issue ... if you have to much code nested in each other it will break the highlighting.

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @alallier on October 7, 2016 12:48

@alexandrudima The files I am working on contain sensitive data, so I can't attach them to an issue. I've been meaning to work up a dummy file I can attach to show the problem I am running into.

@ebastuart it doesn't seem to be a nesting problem for me

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @jdalton on October 13, 2016 22:2

If you're looking for a large file which stops highlighting you can check out:
https://raw.githubusercontent.com/lodash/lodash/4.16.4/lodash.js

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @alexandrudima on October 24, 2016 17:17

@jdalton we regularly update our JavaScript TM language (we take it from https://github.com/Microsoft/TypeScript-TmLanguage). With the latest version we have in master (insiders build stream) lodash appears to be colored fine.

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @djlooney on November 14, 2016 20:35

Not sure if you are still in the market for a nonsensitive file. Here is an un-minified js resource loaded by twitch.tv which has issues for me starting at line 4825. The lodash file from earlier in the thread has no issues for me.

https://gist.githubusercontent.com/djlooney/4ec6a2a55f778d11bd95eb9bbc87fe28/raw/6c7cc59860114382420eec82d55a7bd630f94133/sample.js

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

Closing as fixed

@ebastuart Please let us know if you still see this issue in VSCode 1.8.1+. If you do, please provide some sample code so we can investigate.

Thanks

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

From @djlooney on January 10, 2017 2:39

I am still having issues with some of my large files on 1.8.1. Attached is a js file which has no syntax highlighting after line 4823, and an attached screenshot of what I see.

https://gist.githubusercontent.com/djlooney/4ec6a2a55f778d11bd95eb9bbc87fe28/raw/6c7cc59860114382420eec82d55a7bd630f94133/sample.js

http://imgur.com/a/B2A4U

@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 10, 2017

I just tested this with the latest grammar. Using the file that @djlooney provided, I see highlighting break in a number of places, staring at around line 3274:

screen shot 2017-01-09 at 8 11 29 pm

sheetalkamat added a commit that referenced this issue Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant