Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less Than Operator Breaking JSX/TSX highlighting #430

Closed
mjbvz opened this issue Mar 13, 2017 · 1 comment
Closed

Less Than Operator Breaking JSX/TSX highlighting #430

mjbvz opened this issue Mar 13, 2017 · 1 comment

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 13, 2017

From @indapublic on March 13, 2017 0:37

  • VSCode Version: Version 1.10.2 (1.10.2)
  • OS Version: OSX 10.12.3 (16D32)

Code example:

render() {
    return this.props.data.weekDays.filter((weekDay, index) => (this.state.showAll || index < 3)).map((weekDay, key) => (
      <p key={key}>
        {weekDay.label} {this.props.data[weekDay.id].start} - {this.props.data[weekDay.id].finish}
      </p>
    ))
  }

Highlight example:
screen shot 2017-03-13 at 10 35 28

If I will change index < 3 to 3 > index, all is fine

screen shot 2017-03-13 at 10 37 08

Copied from original issue: microsoft/vscode#22498

@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 13, 2017

From @kjnsn on March 13, 2017 6:1

Confirmed. I'll have a look into it!

@mjbvz mjbvz changed the title Invalid JS highlight Less Than Operator Breaking JSX/TSX highlighting Mar 13, 2017
kjnsn pushed a commit to kjnsn/TypeScript-TmLanguage that referenced this issue Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant